Add StytchBiometrics Demo App - Fix Biometrics Funk#371
Merged
nidal-stytch merged 2 commits intomainfrom Jan 9, 2025
Merged
Conversation
nidal-stytch
force-pushed
the
Biometrics
branch
4 times, most recently
from
911c139 to
82e6388
Compare
nidal-stytch
force-pushed
the
Biometrics
branch
8 times, most recently
from
4144224 to
ab30e5b
Compare
nidal-stytch
changed the title
nidal-stytch
force-pushed
the
Biometrics
branch
10 times, most recently
from
5eb5a10 to
516867f
Compare
| } | ||
|
|
||
| #if !os(tvOS) && !os(watchOS) | ||
| /// Indicates if biometrics are available |
Contributor
There was a problem hiding this comment.
Why remove this? It seems somewhat important to know if the user even can register biometrics, no?
Contributor
Author
There was a problem hiding this comment.
Ok fair point, I added it back in. I just didn't see it being used internally and got a little hasty in deleting it, good catch.
nidal-stytch
force-pushed
the
Biometrics
branch
from
516867f to
a3499ba
Compare
nidal-stytch
force-pushed
the
Biometrics
branch
from
a3499ba to
d0d8faf
Compare
jhaven-stytch
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS: repeated faceID prompts after upgrading to 0.52.0
Changes:
.biometricKeyRegistration..biometricKeyRegistrationholds the biometric registration id, which is not relevant for authentication but will help us check for orphaned registrations or if registrations exist in the first place, its how we manage registrations in the api..privateKeyRegistrationshould only ever be read during biometric registration now as reading it will show the face id prompt and we were doing that way too often.Checklist: